Merged
Conversation
fgetc() returns an int so it can represent every byte value plus EOF. Casting that result directly to char loses the EOF sentinel and can produce an ordinary byte value instead, depending on the platform's char signedness.
A unified diff that removes all lines from a file uses a new file range of 0,0, but that does not mean the file should be deleted. We were inferring Operation::Delete from that hunk header alone, so applying such a patch removed the target file entirely instead of leaving it as an empty file. Match traditional patch behavior by only inferring add/delete from /dev/null headers when file paths are present, and keep the old hunk-range fallback for headerless cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see commits